Skip to content

Added address info for modbus.binary_sensor#17340

Merged
frenck merged 2 commits into
home-assistant:currentfrom
dontbug:patch-2
Apr 15, 2021
Merged

Added address info for modbus.binary_sensor#17340
frenck merged 2 commits into
home-assistant:currentfrom
dontbug:patch-2

Conversation

@dontbug
Copy link
Copy Markdown
Contributor

@dontbug dontbug commented Apr 8, 2021

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Apr 8, 2021
@homeassistant
Copy link
Copy Markdown

Hi @dontbug,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@dontbug
Copy link
Copy Markdown
Contributor Author

dontbug commented Apr 8, 2021

Hi @dontbug,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

done

Comment thread source/_integrations/modbus.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Apr 8, 2021
Added address of the register for binary sensor
Fixed input_type (type: string)
@dontbug dontbug requested a review from frenck April 8, 2021 16:11
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dontbug 👍

@frenck frenck merged commit a5295e0 into home-assistant:current Apr 15, 2021
@probot-home-assistant probot-home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Apr 15, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants