Added short explanation and units#17241
Closed
csoltenborn wants to merge 2 commits into
Closed
Conversation
21 tasks
See commit 82efeded212da103e316d84d74bdac1483c51781
frenck
approved these changes
Apr 6, 2021
Member
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Member
|
Closing PR as the parent PR has been closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Weather templates currently can not be created such that they support both Metric and Imperial unit systems (see this comment for details). This PR fixes that problem by requiring certain units for the template values, and by converting them to the appropriate units in the
WeatherTemplateclass, where information on the configured unit system is available. The required units are added to documentation with this PR.Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.