Skip to content

Added short explanation and units#17241

Closed
csoltenborn wants to merge 2 commits into
home-assistant:nextfrom
csoltenborn:correct_weather_template_units
Closed

Added short explanation and units#17241
csoltenborn wants to merge 2 commits into
home-assistant:nextfrom
csoltenborn:correct_weather_template_units

Conversation

@csoltenborn
Copy link
Copy Markdown
Contributor

Proposed change

Weather templates currently can not be created such that they support both Metric and Imperial unit systems (see this comment for details). This PR fixes that problem by requiring certain units for the template values, and by converting them to the appropriate units in the WeatherTemplate class, where information on the configured unit system is available. The required units are added to documentation with this PR.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Apr 2, 2021
See commit 82efeded212da103e316d84d74bdac1483c51781
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Apr 6, 2021
@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 23, 2022

Closing PR as the parent PR has been closed.

@frenck frenck closed this Jan 23, 2022
@probot-home-assistant probot-home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Jan 23, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants