Skip to content

Add newly supported bulbs for tplink#17125

Merged
frenck merged 2 commits into
home-assistant:nextfrom
superm1:tplink-fallback
Apr 7, 2021
Merged

Add newly supported bulbs for tplink#17125
frenck merged 2 commits into
home-assistant:nextfrom
superm1:tplink-fallback

Conversation

@superm1
Copy link
Copy Markdown
Contributor

@superm1 superm1 commented Mar 25, 2021

Proposed change

The tplink integration previously had rigid requirements for which bulbs could be supported. The underlying libraries for it had to be updated to add any bulb. Add the definition of some new bulbs, and also allow unknown bulbs to operate in safe ranges rather than causing crashes.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Mar 25, 2021
@superm1
Copy link
Copy Markdown
Contributor Author

superm1 commented Apr 7, 2021

@frenck the matching code PR for this was merged, should this be merged now too to to match the next release?

@frenck frenck added this to the 2021.4.0 milestone Apr 7, 2021
Comment thread source/_integrations/tplink.markdown Outdated
@frenck frenck added the parent-merged The parent PR has been merged already label Apr 7, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the notification @superm1 👍

@frenck frenck merged commit 8395946 into home-assistant:next Apr 7, 2021
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Apr 7, 2021
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Apr 7, 2021
frenck added a commit that referenced this pull request Apr 7, 2021
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked This PR has been manually picked and merged into the current branch cla-signed has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants