Add newly supported bulbs for tplink#17125
Merged
Merged
Conversation
21 tasks
Contributor
Author
|
@frenck the matching code PR for this was merged, should this be merged now too to to match the next release? |
frenck
reviewed
Apr 7, 2021
frenck
added a commit
that referenced
this pull request
Apr 7, 2021
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The
tplinkintegration previously had rigid requirements for which bulbs could be supported. The underlying libraries for it had to be updated to add any bulb. Add the definition of some new bulbs, and also allow unknown bulbs to operate in safe ranges rather than causing crashes.Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.