Skip to content

Update zwave_js docs to reflect changes in Z-Wave JS 7.0.0#17053

Merged
MartinHjelmare merged 7 commits into
home-assistant:nextfrom
raman325:zwave_js_7
Mar 30, 2021
Merged

Update zwave_js docs to reflect changes in Z-Wave JS 7.0.0#17053
MartinHjelmare merged 7 commits into
home-assistant:nextfrom
raman325:zwave_js_7

Conversation

@raman325
Copy link
Copy Markdown
Contributor

Proposed change

Z-Wave JS 7.0.0 changes some things about the events we track. Docs must be updated accordingly

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Mar 19, 2021
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Mar 19, 2021
@raman325 raman325 changed the title Update docs to reflect changes in Z-Wave JS 7.0.0 and to add the new notification event type Update zwave_js docs to reflect changes in Z-Wave JS 7.0.0 Mar 19, 2021
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the event names and data attributes.

@raman325
Copy link
Copy Markdown
Contributor Author

raman325 commented Mar 25, 2021

We need to update the event names and data attributes.

I thought I did? Which am I missing?

EDIT: Found it, resolved

@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Mar 25, 2021
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to write what each event is called now and change line 139 where the old event name is written.

Comment thread source/_integrations/zwave_js.markdown Outdated
Comment thread source/_integrations/zwave_js.markdown
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 17072f3 into home-assistant:next Mar 30, 2021
@raman325 raman325 deleted the zwave_js_7 branch March 30, 2021 20:51
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants