Update zwave_js docs to reflect changes in Z-Wave JS 7.0.0#17053
Merged
Conversation
21 tasks
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
We need to update the event names and data attributes.
Contributor
Author
I thought I did? Which am I missing? EDIT: Found it, resolved |
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
We need to write what each event is called now and change line 139 where the old event name is written.
…notification event type
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Z-Wave JS 7.0.0changes some things about the events we track. Docs must be updated accordinglyType of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.