Skip to content

Support preset modes and percentage for mqtt fan#17048

Merged
frenck merged 4 commits intohome-assistant:currentfrom
jbouwh:percentage-and-preset-mode-support-for-mqtt-fan
Mar 29, 2021
Merged

Support preset modes and percentage for mqtt fan#17048
frenck merged 4 commits intohome-assistant:currentfrom
jbouwh:percentage-and-preset-mode-support-for-mqtt-fan

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Mar 18, 2021

Proposed change

The fan entity model has changed. The code and documentation has updated to support fan speed percentage and preset mode functions. Using legacy speeds is deprecated.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 18, 2021
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Mar 18, 2021
Comment thread source/_integrations/fan.mqtt.markdown Outdated
Copy link
Copy Markdown
Contributor Author

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One abbreviation 'pr_mode_value_tpl' should be corrected,

Comment thread source/_docs/mqtt/discovery.markdown Outdated
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Mar 26, 2021
@jbouwh jbouwh requested a review from emontnemery March 26, 2021 09:42
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frenck frenck merged commit 9e5d183 into home-assistant:current Mar 29, 2021
@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Mar 29, 2021
@emontnemery
Copy link
Copy Markdown
Contributor

There was a mistake here, this should have targetted next branch, not current (core PR is not in 2021.3, but will be in 2021.4).

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 29, 2021

Will adjust this manually

frenck added a commit that referenced this pull request Mar 29, 2021
frenck added a commit that referenced this pull request Mar 29, 2021
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 29, 2021

Done, it has been reverted on current and is now re-applied on next.

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants