Skip to content

Update modbus configuration to use new #16678

Merged
frenck merged 4 commits intohome-assistant:nextfrom
janiversen:modbus_new_config
Mar 29, 2021
Merged

Update modbus configuration to use new #16678
frenck merged 4 commits intohome-assistant:nextfrom
janiversen:modbus_new_config

Conversation

@janiversen
Copy link
Copy Markdown
Member

@janiversen janiversen commented Feb 21, 2021

Proposed change

Update documentation to reflect the new modbus configuration.

Moved the platform pages into the modbus (integration) page, since this is a list of integrations.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • [ x] Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:

home-assistant/core#46591

  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • [x ] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [ x] The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Feb 21, 2021
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Feb 21, 2021
@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 21, 2021

Is this related to a parent PR?

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Feb 21, 2021
@janiversen
Copy link
Copy Markdown
Member Author

yes #46591 I wrote that above but did not make a link, sorry for that. I have updated the text

@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Feb 21, 2021
@janiversen
Copy link
Copy Markdown
Member Author

Update to reflect documentation error, that was already merged in current.

@MartinHjelmare MartinHjelmare added the parent-merged The parent PR has been merged already label Mar 27, 2021
@frenck frenck self-requested a review March 29, 2021 07:18
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @janiversen 👍

@frenck frenck merged commit 18615a1 into home-assistant:next Mar 29, 2021
@probot-home-assistant probot-home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Mar 29, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2021
@janiversen janiversen deleted the modbus_new_config branch March 31, 2021 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants