Skip to content

Add Xiaomi Miio vacuum config flow#16625

Merged
frenck merged 1 commit intohome-assistant:nextfrom
starkillerOG:patch-37
Feb 22, 2021
Merged

Add Xiaomi Miio vacuum config flow#16625
frenck merged 1 commit intohome-assistant:nextfrom
starkillerOG:patch-37

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

Proposed change

Add Xiaomi Miio vacuum config flow

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Feb 17, 2021
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Feb 17, 2021
@klaasnicolaas klaasnicolaas added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Feb 18, 2021
Copy link
Copy Markdown
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now use {% include integrations/config_flow.md %} for the setup instructions.

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@klaasnicolaas Thanks!
What would be the text that is displayed for {% include integrations/config_flow.md %}?

@MartinHjelmare MartinHjelmare added the parent-merged The parent PR has been merged already label Feb 22, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{% include integrations/config_flow.md %} would be an option if all platforms are migrated to a configuration flow. The Xiaomi Miio integration is a bit of an odd duck in this case.

I think we can just move forward with this one, and consider merging all configuration chapters in a single one, once the migration is fully completed.

@frenck frenck merged commit bcde45c into home-assistant:next Feb 22, 2021
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Feb 22, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants