Skip to content

Adjust entities special row example#16219

Merged
frenck merged 4 commits intocurrentfrom
spacegaier-patch-4
Jan 18, 2021
Merged

Adjust entities special row example#16219
frenck merged 4 commits intocurrentfrom
spacegaier-patch-4

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Jan 18, 2021

Proposed change

Type call-service was phased out in last February (home-assistant/frontend#4744 and #12545), but the example still used it. Also while I was at it, I extended the example a bit to show more variations. Plus added a screenshot.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@spacegaier spacegaier marked this pull request as draft January 18, 2021 08:34
@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 18, 2021
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Jan 18, 2021
@spacegaier spacegaier removed the has-parent This PR has a parent PR in another repo label Jan 18, 2021
@spacegaier spacegaier marked this pull request as ready for review January 18, 2021 08:39
@probot-home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.
(message by DocsTargetBranch)

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Jan 18, 2021
@spacegaier spacegaier removed has-parent This PR has a parent PR in another repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 18, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @spacegaier 👍

@frenck frenck merged commit 720d097 into current Jan 18, 2021
@frenck frenck deleted the spacegaier-patch-4 branch January 18, 2021 13:41
@probot-home-assistant probot-home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Jan 18, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants