Skip to content

Daikin: Add region changing note#16153

Merged
frenck merged 2 commits intohome-assistant:currentfrom
deadman96385:patch-4
Jan 11, 2021
Merged

Daikin: Add region changing note#16153
frenck merged 2 commits intohome-assistant:currentfrom
deadman96385:patch-4

Conversation

@deadman96385
Copy link
Copy Markdown
Contributor

Proposed change

Adding a note about an http api endpoint that can be used to change the region of the controller so that for example a US controller can be controlled by the European Daikin Online Controller app.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Jan 11, 2021
@deadman96385
Copy link
Copy Markdown
Contributor Author

How should I fix that lint error it is a url? I looked at other integration pages and they are doing it the same way I am. Like here https://github.com/home-assistant/home-assistant.io/blob/current/source/_integrations/android_ip_webcam.markdown#other-sensors

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is not the URL it is the text above it (line 118).

Comment thread source/_integrations/daikin.markdown Outdated
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @deadman96385 👍

@frenck frenck merged commit 0b2d547 into home-assistant:current Jan 11, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants