Skip to content

Recommend using Python ADB approach for Android TV setup#16141

Merged
frenck merged 2 commits into
home-assistant:currentfrom
JeffLIrion:patch-30
Jan 10, 2021
Merged

Recommend using Python ADB approach for Android TV setup#16141
frenck merged 2 commits into
home-assistant:currentfrom
JeffLIrion:patch-30

Conversation

@JeffLIrion
Copy link
Copy Markdown
Contributor

Proposed change

Add a recommendation for using Python ADB approach over the ADB server approach.

Setting up an ADB server and debugging issues connecting HA <--> ADB server <--> Android TV device are common pitfalls for users setting up this integration. By contrast, using the Python ADB approach requires no setup and is easier to debug.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Jan 10, 2021
Comment thread source/_integrations/androidtv.markdown
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @JeffLIrion 👍

Time for me to start deprecating that add-on as well. 😉

@frenck frenck merged commit bd3a688 into home-assistant:current Jan 10, 2021
@JeffLIrion
Copy link
Copy Markdown
Contributor Author

Time for me to start deprecating that add-on as well. 😉

I wouldn't suggest deprecating it, since that would require a lot of people to change their config. My reason for adding this note was because a lot of people's first step when trying to setup the Android TV integration is to install the add-on or ask "I installed HA using <docker, virtual environment, etc>, how do I setup an ADB server?"

I can't guarantee that the Python implementation (adb-shell package) works perfectly on every device, but I haven't heard about any issues with it lately, and people are making the setup of this integration harder than it needs to be.

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 10, 2021

The problem is that the add-on will reach some sort of end of life. As the binaries won't hold up with the next OS upgrades on the Docker containers.

@github-actions github-actions Bot locked and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants