Skip to content

Add unsupported page for job conditions#15740

Merged
ludeeus merged 5 commits intocurrentfrom
unsupported-job-conditions
Nov 24, 2020
Merged

Add unsupported page for job conditions#15740
ludeeus merged 5 commits intocurrentfrom
unsupported-job-conditions

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Nov 24, 2020

Proposed change

Adds a more-info page for job_conditions unsupported reason.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Nov 24, 2020
@ludeeus ludeeus marked this pull request as ready for review November 24, 2020 09:16
Comment thread source/more-info/unsupported/job_conditions.markdown Outdated
@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 24, 2020
@ludeeus ludeeus removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Nov 24, 2020
Comment thread source/more-info/unsupported/job_conditions.markdown Outdated
Comment thread source/more-info/unsupported/job_conditions.markdown Outdated
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Nov 24, 2020
@ludeeus ludeeus merged commit b273ccd into current Nov 24, 2020
@probot-home-assistant probot-home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Nov 24, 2020
@ludeeus ludeeus deleted the unsupported-job-conditions branch November 24, 2020 10:49
@probot-home-assistant probot-home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Nov 24, 2020
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants