Skip to content

Logbook Card#15498

Merged
frenck merged 2 commits intohome-assistant:currentfrom
zsarnett:logbook-card
Nov 19, 2020
Merged

Logbook Card#15498
frenck merged 2 commits intohome-assistant:currentfrom
zsarnett:logbook-card

Conversation

@zsarnett
Copy link
Contributor

Proposed change

Add Log book card Docs

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: Logbook Card frontend#6976
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@klaasnicolaas klaasnicolaas added has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 30, 2020
frenck
frenck previously approved these changes Nov 6, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Nov 6, 2020
@klaasnicolaas
Copy link
Member

O no! We forgot this PR for the 0.118 release

@klaasnicolaas klaasnicolaas added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Nov 19, 2020
@zsarnett
Copy link
Contributor Author

Damn.... Uh should I rebase to the current then?

@klaasnicolaas
Copy link
Member

I think that's the best option, but @frenck knows about it and he'll take a look at it when he wakes up 😄

@frenck frenck changed the base branch from next to current November 19, 2020 07:47
@frenck frenck dismissed their stale review November 19, 2020 07:47

The base branch was changed.

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 19, 2020
@probot-home-assistant probot-home-assistant bot added current This PR goes into the current branch and removed next This PR goes into the next branch labels Nov 19, 2020
@frenck
Copy link
Member

frenck commented Nov 19, 2020

Changed target to current to make sure it ends up in the 0.118 (current) release documentation.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 👍

Sorry about missing this PR!

@frenck frenck merged commit d084069 into home-assistant:current Nov 19, 2020
@probot-home-assistant probot-home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Nov 19, 2020
javicalle pushed a commit to javicalle/home-assistant.io that referenced this pull request Nov 21, 2020
Co-authored-by: Franck Nijhof <git@frenck.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! hacktoberfest-accepted has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants