Skip to content

updated nuki documentation#15244

Closed
pree wants to merge 1 commit into
home-assistant:nextfrom
pree:nuki/doorsensor
Closed

updated nuki documentation#15244
pree wants to merge 1 commit into
home-assistant:nextfrom
pree:nuki/doorsensor

Conversation

@pree
Copy link
Copy Markdown
Member

@pree pree commented Oct 14, 2020

Proposed change

This updates the nuki documentation due to breaking changes in my PR in homeassistant/core.
(home-assistant/core#40933)

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 14, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR new-feature This PR adds documentation for a new Home Assistant feature to an existing integration hacktoberfest-accepted labels Oct 25, 2020
@frenck frenck added the parent-merged The parent PR has been merged already label Apr 6, 2021
@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 6, 2021

The parent for this PR is merged, however, a wild merge conflict appeared out of nowhere! 🙈

Could you take a look @pree?

@pree
Copy link
Copy Markdown
Member Author

pree commented Apr 6, 2021

I think this PR is obsolete, the parent doesn't change the nuki configuration, since it moved to config_flow anyway. Should we document, that the doorsensor is now also available? Otherwise we can close this PR

@apmosss
Copy link
Copy Markdown

apmosss commented Apr 10, 2021

I think you should document that door sensor is now also available.

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 25, 2021

This PR is obsolete.

@frenck frenck closed this Apr 25, 2021
@probot-home-assistant probot-home-assistant Bot added Invalid and removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted has-parent This PR has a parent PR in another repo Invalid new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants