Skip to content

Add config flow and restore_light_state to ISY994#13369

Merged
bdraco merged 3 commits into
home-assistant:nextfrom
shbatm:next
May 10, 2020
Merged

Add config flow and restore_light_state to ISY994#13369
bdraco merged 3 commits into
home-assistant:nextfrom
shbatm:next

Conversation

@shbatm
Copy link
Copy Markdown
Contributor

@shbatm shbatm commented May 9, 2020

Proposed change

Update method for adding the integration to include using the new config flow via the integrations page.

Add the restore_light_state parameter: The ISY994 integration now includes a restore_light_state option. In 0.109.0, a change was made to restore a light's brightness to the previous state when turned on with no brightness parameter. This was, in part, to fix an issue where the light would turn on to full brightness when no parameters were given, regardless of the physical device's On Level brightness setting. Using the On Level is now supported and this is being made the default behavior to keep it the same as turning on the physical switch. To keep the current behavior and use Home Assistant's last brightness, set the restore_light_state is set to True or enable the option in the new config flow options.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels May 9, 2020
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 9, 2020

@shbatm Please add ha_config_flow: true to the attributes at the top of the file

Comment thread source/_integrations/isy994.markdown Outdated
@klaasnicolaas klaasnicolaas added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label May 9, 2020
@frenck frenck added the parent-merged The parent PR has been merged already label May 9, 2020
@shbatm
Copy link
Copy Markdown
Contributor Author

shbatm commented May 9, 2020

Changes made.

@bdraco bdraco dismissed klaasnicolaas’s stale review May 10, 2020 20:01

Submitter completed requested changes

@bdraco bdraco merged commit 4fbd8bf into home-assistant:next May 10, 2020
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants