Add config flow and restore_light_state to ISY994#13369
Merged
Conversation
24 tasks
Member
|
@shbatm Please add |
klaasnicolaas
previously requested changes
May 9, 2020
Contributor
Author
|
Changes made. |
bdraco
approved these changes
May 9, 2020
Submitter completed requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Update method for adding the integration to include using the new config flow via the integrations page.
Add the
restore_light_stateparameter: The ISY994 integration now includes a restore_light_state option. In 0.109.0, a change was made to restore a light's brightness to the previous state when turned on with no brightness parameter. This was, in part, to fix an issue where the light would turn on to full brightness when no parameters were given, regardless of the physical device's On Level brightness setting. Using the On Level is now supported and this is being made the default behavior to keep it the same as turning on the physical switch. To keep the current behavior and use Home Assistant's last brightness, set the restore_light_state is set to True or enable the option in the new config flow options.Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.