Skip to content

Remove base_url, add external_url & internal_url#13307

Merged
frenck merged 4 commits into
nextfrom
frenck-2020-0470
May 8, 2020
Merged

Remove base_url, add external_url & internal_url#13307
frenck merged 4 commits into
nextfrom
frenck-2020-0470

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 5, 2020

Proposed change

This PR updates the documentation for the parent PR.

Removes the use of base_url from our documentation, as it is deprecated.
Insert external_url and internal_url core configuration as the replacements.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels May 5, 2020
@frenck frenck self-assigned this May 5, 2020
@frenck frenck added in-progress This PR/Issue is currently being worked on new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels May 5, 2020
@frenck frenck marked this pull request as ready for review May 7, 2020 19:08
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label May 7, 2020
Comment thread source/_docs/ecosystem/certificates/lets_encrypt.markdown
Comment thread source/_docs/ecosystem/haproxy.markdown
Comment thread source/_docs/ecosystem/nginx.markdown
balloob
balloob previously approved these changes May 7, 2020
@frenck
Copy link
Copy Markdown
Member Author

frenck commented May 7, 2020

Done!

@frenck frenck merged commit 3701a98 into next May 8, 2020
@frenck frenck deleted the frenck-2020-0470 branch May 8, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants