Skip to content

Add description of manual config flow for Plex#13117

Merged
frenck merged 3 commits into
home-assistant:nextfrom
jjlawren:plex_re-add_manual_flow
May 8, 2020
Merged

Add description of manual config flow for Plex#13117
frenck merged 3 commits into
home-assistant:nextfrom
jjlawren:plex_re-add_manual_flow

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

Proposed change

Describe manual configuration added to the Plex integration config flow.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Apr 21, 2020
frenck
frenck previously approved these changes Apr 21, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Apr 21, 2020
@frenck frenck added the parent-merged The parent PR has been merged already label May 6, 2020
@jjlawren
Copy link
Copy Markdown
Contributor Author

jjlawren commented May 8, 2020

@frenck I'm thinking of updating this further to take home-assistant/core#34546 into account and remove references to the legacy YAML config. The manual config flow step was added specifically in response to deprecating YAML. Thoughts?

Edit: I did it.

@jjlawren jjlawren force-pushed the plex_re-add_manual_flow branch from 4bc9209 to aa04c77 Compare May 8, 2020 04:24
@jjlawren jjlawren requested a review from frenck May 8, 2020 04:25
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jjlawren 👍

@frenck frenck merged commit 73b5037 into home-assistant:next May 8, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels May 8, 2020
@jjlawren jjlawren deleted the plex_re-add_manual_flow branch May 9, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants