Skip to content

Update yeelight.markdown#13024

Closed
jonwaland wants to merge 1 commit into
home-assistant:currentfrom
jonwaland:patch-3
Closed

Update yeelight.markdown#13024
jonwaland wants to merge 1 commit into
home-assistant:currentfrom
jonwaland:patch-3

Conversation

@jonwaland
Copy link
Copy Markdown
Contributor

@jonwaland jonwaland commented Apr 16, 2020

qualify the need to quote off

Proposed change

documentation update as per home-assistant/core#34276

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

qualify the need to quote off
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Apr 16, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 17, 2020

While I do appreciate the contribution in general, I'm not going to merge this in.

This is not a specific issue/thing for this integration, but how YAML works.
We can actually add this warning to almost any place. 🤷

@frenck frenck closed this Apr 17, 2020
@jonwaland
Copy link
Copy Markdown
Contributor Author

@frenck

Maybe https://www.home-assistant.io/docs/configuration/yaml/ should be updated then, given this would likely be a common error

@jonwaland jonwaland deleted the patch-3 branch April 17, 2020 08:03
@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 17, 2020

Yeah an addition the common issues sections might be a good idea 👍

@jonwaland jonwaland mentioned this pull request Apr 18, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants