Skip to content

Add battery_charging to binary_sensor#12965

Closed
bdraco wants to merge 1 commit intocurrentfrom
bdraco-patch-4
Closed

Add battery_charging to binary_sensor#12965
bdraco wants to merge 1 commit intocurrentfrom
bdraco-patch-4

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 14, 2020

Proposed change

Add battery_charging to binary_sensor

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Apr 14, 2020
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Apr 14, 2020
Copy link
Copy Markdown
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just realized the wrong branch was targeted here. I think it should be next and not current because the change is dependent on code being released. Otherwise the change looks good.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 14, 2020

I'll close and open a new one.

@dshokouhi thanks for catching that 👍

@bdraco bdraco closed this Apr 14, 2020
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 14, 2020

#12975

@bdraco bdraco deleted the bdraco-patch-4 branch October 4, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants