Skip to content

Update modbus text, with warning (relevant for V1.08)#12762

Merged
fabaff merged 2 commits into
home-assistant:nextfrom
janiversen:modbus_twister
Apr 12, 2020
Merged

Update modbus text, with warning (relevant for V1.08)#12762
fabaff merged 2 commits into
home-assistant:nextfrom
janiversen:modbus_twister

Conversation

@janiversen
Copy link
Copy Markdown
Member

@janiversen janiversen commented Apr 8, 2020

Proposed change

pymodbus issues a silly warning, that confuses our users, text is therefore updated to inform users that the warning has no effect on the integration.

Also added a section about how to make a communication debug log, which helps solve issues.

This change is relevant for version 1.0.8 and later.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • [x ] Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Describe the warning from pymodbus and
furthermore describe how to add debug.
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Apr 8, 2020
@janiversen janiversen changed the title Update modbus text, with warning Update modbus text, with warning V1.08) Apr 9, 2020
@janiversen janiversen changed the title Update modbus text, with warning V1.08) Update modbus text, with warning (relevant for V1.08) Apr 9, 2020
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Apr 9, 2020
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fabaff fabaff merged commit 659ce1d into home-assistant:next Apr 12, 2020
@janiversen janiversen deleted the modbus_twister branch April 12, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants