Skip to content

Add documentation for Modbus light and fan#12640

Closed
vzahradnik wants to merge 2 commits intohome-assistant:nextfrom
Lutemi:feature/modbus-fan-and-light
Closed

Add documentation for Modbus light and fan#12640
vzahradnik wants to merge 2 commits intohome-assistant:nextfrom
Lutemi:feature/modbus-fan-and-light

Conversation

@vzahradnik
Copy link
Copy Markdown
Contributor

Proposed change

This pull request adds documentation for new integrations, Modbus fan and Modbus light.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Apr 2, 2020
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Apr 3, 2020
Comment thread source/_integrations/fan.modbus.markdown Outdated
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vzahradnik!
I've reviewed it and left a couple of suggestions. Could you take a look? Thanks 👍

Comment thread source/_integrations/fan.modbus.markdown Outdated
Comment thread source/_integrations/light.modbus.markdown Outdated
Comment thread source/_integrations/light.modbus.markdown Outdated
Comment thread source/_integrations/light.modbus.markdown Outdated
Comment thread source/_integrations/fan.modbus.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Apr 3, 2020
@vzahradnik
Copy link
Copy Markdown
Contributor Author

@frenck thanks! I will take a look.

@vzahradnik
Copy link
Copy Markdown
Contributor Author

@frenck, I committed all your proposed changes. Thanks for pointing them out!

@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Apr 3, 2020
frenck
frenck previously approved these changes Apr 3, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Apr 3, 2020
@vzahradnik
Copy link
Copy Markdown
Contributor Author

As discussed in PR home-assistant/core#33551, I will split the Fan and Light Modbus entities into two separate PRs. Therefore, I will close this PR, and will create two separate documentation PRs later.

@vzahradnik vzahradnik closed this Oct 12, 2020
@probot-home-assistant probot-home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Oct 12, 2020
@vzahradnik vzahradnik deleted the feature/modbus-fan-and-light branch May 3, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants