Skip to content

Add remote platform docs to directv#12365

Merged
frenck merged 2 commits into
home-assistant:nextfrom
ctalkington:patch-1
Apr 2, 2020
Merged

Add remote platform docs to directv#12365
frenck merged 2 commits into
home-assistant:nextfrom
ctalkington:patch-1

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented Mar 14, 2020 •
edited
Loading

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added next This PR goes into the next branch has-parent This PR has a parent PR in another repo labels Mar 14, 2020
frenck
frenck requested changes Mar 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ctalkington!

I've left some comments, could you please take a look? Thanks! 👍

Comment thread source/_integrations/directv.markdown Outdated
Comment thread source/_integrations/directv.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 16, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 17, 2020

Looks good! Awaiting for it to get out of WIP :)

@ctalkington ctalkington mentioned this pull request Mar 17, 2020
Merged
20 tasks
@frenck frenck added the parent-merged The parent PR has been merged already label Apr 2, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 2, 2020

@ctalkington What is the status of this docs PR? Since the parent PR has been merged...

@frenck frenck closed this Apr 2, 2020
@probot-home-assistant probot-home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Apr 2, 2020
@ctalkington
Copy link
Copy Markdown
Contributor Author

ctalkington commented Apr 2, 2020 •
edited
Loading

@frenck sorry juggling a bit here between platforms. this is ready to merge

@frenck frenck reopened this Apr 2, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 2, 2020

Check thanks! 👍

@frenck frenck changed the title WIP: Add remote platform docs to directv Add remote platform docs to directv Apr 2, 2020
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Apr 2, 2020
@frenck frenck merged commit 9efb32b into home-assistant:next Apr 2, 2020
@ctalkington ctalkington deleted the patch-1 branch April 2, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

Assignees

@ctalkington ctalkington

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ctalkington @frenck @klaasnicolaas