Skip to content

Add homekit camera docs#12303

Merged
frenck merged 11 commits into
home-assistant:nextfrom
xdissent:homekit-camera
May 6, 2020
Merged

Add homekit camera docs#12303
frenck merged 11 commits into
home-assistant:nextfrom
xdissent:homekit-camera

Conversation

@xdissent
Copy link
Copy Markdown
Contributor

@xdissent xdissent commented Mar 7, 2020

Proposed change

Add homekit camera docs.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Mar 7, 2020
@xdissent xdissent mentioned this pull request Mar 7, 2020
Merged
20 tasks
frenck
frenck requested changes Mar 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @xdissent!

Reviewed it, and left some comments. Could you please take a look? Thanks! 👍

Comment thread source/_integrations/homekit.markdown Outdated
Comment thread source/_integrations/homekit.markdown Outdated
Comment thread source/_integrations/homekit.markdown Outdated
Comment thread source/_integrations/homekit.markdown Outdated
Comment thread source/_integrations/homekit.markdown Outdated
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration in-progress This PR/Issue is currently being worked on labels Mar 7, 2020
@xdissent @frenck
Apply suggestions from code review
30ca3f8 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@Jc2k
Copy link
Copy Markdown
Member

Jc2k commented Mar 9, 2020

Should it be explicit that "Secure Video" is not currently supported? (This is where the an AppleTV hub monitors the video feed and stores "interesting" clips in a users iCloud account). As i'm pretty sure that will be one of the first questions people ask when they see this feature :)

@Jc2k
Copy link
Copy Markdown
Member

Jc2k commented Mar 9, 2020

A common issue with other ffmpeg based HomeKit cameras is what happens when 2 people access the same HomeKit camera at once. Should we explicitly document how many simultaneous streams are supported? Is it unlimited? Does it depend on the source camera? Can it only ever support 1 stream?

@stickpin stickpin mentioned this pull request May 4, 2020
Closed
20 tasks
@probot-home-assistant probot-home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label May 4, 2020
@bdraco bdraco reopened this May 5, 2020
@bdraco bdraco added the parent-merged The parent PR has been merged already label May 5, 2020
@stickpin stickpin mentioned this pull request May 5, 2020
Merged
20 tasks
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 5, 2020

Secure Video

@Jc2k Good call. I added that

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 5, 2020

A common issue with other ffmpeg based HomeKit cameras is what happens when 2 people access the same HomeKit camera at once. Should we explicitly document how many simultaneous streams are supported? Is it unlimited? Does it depend on the source camera? Can it only ever support 1 stream?

The HomeKit will UI will tell them that only one stream is supported so I think this is ok to leave it out

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 5, 2020

@xdissent Since merging this is blocking home-assistant/core#35238 I went ahead and did the cleanup. I hope that is OK.

bdraco
bdraco previously approved these changes May 5, 2020
View reviewed changes
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 6, 2020

Thanks for the tweaks @frenck

frenck
frenck approved these changes May 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @xdissent!

Awesome feature btw! 🎉

@frenck frenck merged commit b18a75f into home-assistant:next May 6, 2020
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

@bdraco bdraco bdraco left review comments

Assignees

@xdissent xdissent

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xdissent @Jc2k @bdraco @frenck