Add documentation for device type option#12279
Conversation
|
One question still remains:
How can a user find the |
|
@frenck These are the types we know so far, but they get out of date very quickly, so I don't think it's interesting to document them. The user can find the type of his device using the official Broadlink App. But I do not recommend this, because this application is evil. It connects the device to the cloud and prevents it from being controlled by Home Assistant. So the user should stay away from it. The alternatives we have today are Broadlink Manager and this debug tool I've created to debug the API we are using. For now it's a pretty shitty tool, so I think we should stick to Broadlink Manager in the docs. It is important to note that none of this would be necessary if we implemented HELLO_REQUEST (broadlink.discover) within our integration. The device knows its type and sends it in response. It would be so much easier to just say hello. We are violating etiquette and making the user pay for it. |
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
|
Sorry for the immediate closing @felipediel but you will see later on that’s it’s annoying being requested for an unchecked code. To prevent that, some advices :
And I don’t know if you have the right but PR can be reopened, or you can create a new one, so no worries 😉 Thanks a lot for your contribution 👍 Sent with GitHawk |
|
@Quentame Yes, sorry about that. I was on a hurry late at night to send the docs and I worked on an old branch by mistake. I was so tired that I didn't even check my commits and the rest you know. |
Proposed change
Add documentation for device type option.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.