Skip to content

Add ha_domain to integrations frontmatter#12277

Merged
balloob merged 1 commit into
currentfrom
frenck-2020-0247
Mar 6, 2020
Merged

Add ha_domain to integrations frontmatter#12277
balloob merged 1 commit into
currentfrom
frenck-2020-0247

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Mar 5, 2020

Proposed change

This adds ha_domain to the frontmatter of most integrations pages.
Has been scripted by matching up manifest.json from the code base with the documentation repository. The domain is pulled from the manifest.json file.

Reasoning:

Right now, we try to get the domain from the URL in Jekyll using Liquid. However, this isn't 100% reliable anymore. This makes it more explicit and removed the need for all the current logic we have (removing that is out of scope for this PR).

Furthermore, we can start using the brands repository as well, since the logos and icons from that repository rely on the domain, for more info, see:

https://brands.home-assistant.io

Related to #12276

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Mar 5, 2020
@balloob balloob merged commit c81de1d into current Mar 6, 2020
@balloob balloob deleted the frenck-2020-0247 branch March 6, 2020 01:28
felipediel pushed a commit to felipediel/home-assistant.io that referenced this pull request Mar 6, 2020
felipediel pushed a commit to felipediel/home-assistant.io that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants