Add ha_domain to integrations frontmatter#12277
Merged
Merged
Conversation
balloob
approved these changes
Mar 6, 2020
felipediel
pushed a commit
to felipediel/home-assistant.io
that referenced
this pull request
Mar 6, 2020
felipediel
pushed a commit
to felipediel/home-assistant.io
that referenced
this pull request
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This adds
ha_domainto the frontmatter of most integrations pages.Has been scripted by matching up
manifest.jsonfrom the code base with the documentation repository. The domain is pulled from themanifest.jsonfile.Reasoning:
Right now, we try to get the domain from the URL in Jekyll using Liquid. However, this isn't 100% reliable anymore. This makes it more explicit and removed the need for all the current logic we have (removing that is out of scope for this PR).
Furthermore, we can start using the brands repository as well, since the logos and icons from that repository rely on the domain, for more info, see:
https://brands.home-assistant.io
Related to #12276
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.