Reduce weight of integrations page + list everything once#12260
Merged
Conversation
Member
Author
|
Github seems to be having issues with external builds again (the actions failed a couple of times as well). However, Netlify did build. Result for this PR can be found here: https://5e5eee33cac6e200095e18d6--home-assistant-docs.netlify.com/integrations/#all |
Member
|
Nice! Can we still have the main (1st) category on the card? |
Member
Author
|
I did consider that to be honest. So some reasoning why I didn't :
|
Member
Author
|
I could branch of this PR and make a version that just picks the first category. Let's see what it does / how it looks. |
Member
|
I can write you a JS function btw to convert binary-sensor -> Binary Sensor. |
Member
|
I looked at it again, let's drop the category from the card. |
felipediel
pushed a commit
to felipediel/home-assistant.io
that referenced
this pull request
Mar 6, 2020
…tant#12260) * Reduce weight of integrations page + list everything once * Empty commit to re-trigger build * Empty commit to re-trigger build
felipediel
pushed a commit
to felipediel/home-assistant.io
that referenced
this pull request
Mar 6, 2020
…tant#12260) * Reduce weight of integrations page + list everything once * Empty commit to re-trigger build * Empty commit to re-trigger build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed change
This PR focusses on reducing a bit of the integrations listing page, without major restructuring.
Currently, each integration is on the page for each category it is listed in.
This has been adjusted, the integration is just added to the javascript once, with a list of categories on each of them.
The search and filters have been adjusted to deal with that.
As a result, the all integrations page looks way cleaner, is less heavy and less data is transferred.
The downside of this, would be the missing categories on the cards. However, I'm not sure if that is a big "miss". Categories still do work (you can even still search for a category).
The magnitude of reduction: The list of integrations in the source is now 984 instead of 1556. That is more than 30% reduction, including the number of card elements displayed on the all integrations page.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.