Skip to content

Added SAN to the example openssl command#12258

Merged
frenck merged 3 commits into
home-assistant:currentfrom
valbaudo:patch-1
Mar 4, 2020
Merged

Added SAN to the example openssl command#12258
frenck merged 3 commits into
home-assistant:currentfrom
valbaudo:patch-1

Conversation

@valbaudo
Copy link
Copy Markdown
Contributor

@valbaudo valbaudo commented Mar 3, 2020

Proposed change

This ensures that the Home Assistant Companion on Android 10 and iOS 13 (this is what I tested) will correctly connect to the local Home Assistant instance without blocking the connection due to an SSL error.

This is due to compliance with RFC 2818, which states that support for CN fallback (that is the only parameter we are allowed to set with the current openssl command in the docs) is deprecated and only SAN should be used to establish whether a certificate is valid for a certain host or not.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

This ensures that the Home Assistant Companion on Android 10 (this is what I tested) will correctly connect to the local Home Assistant instance. This is due to compliance with RFC 2818, which states that support for CN fallback is deprecated and only SAN should be used to establish whether a certificate is valid or not.
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Mar 3, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vabbb! 👍

@frenck frenck merged commit a913852 into home-assistant:current Mar 4, 2020
felipediel pushed a commit to felipediel/home-assistant.io that referenced this pull request Mar 6, 2020
* Added SAN to the example openssl command

This ensures that the Home Assistant Companion on Android 10 (this is what I tested) will correctly connect to the local Home Assistant instance. This is due to compliance with RFC 2818, which states that support for CN fallback is deprecated and only SAN should be used to establish whether a certificate is valid or not.

* ✏️ Tweaks

* Update tls_self_signed_certificate.markdown

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
felipediel pushed a commit to felipediel/home-assistant.io that referenced this pull request Mar 6, 2020
* Added SAN to the example openssl command

This ensures that the Home Assistant Companion on Android 10 (this is what I tested) will correctly connect to the local Home Assistant instance. This is due to compliance with RFC 2818, which states that support for CN fallback is deprecated and only SAN should be used to establish whether a certificate is valid or not.

* ✏️ Tweaks

* Update tls_self_signed_certificate.markdown

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants