Skip to content

Add details around configuration and options flow#12239

Merged
frenck merged 11 commits into
home-assistant:currentfrom
kit-klein:patch-4
Mar 6, 2020
Merged

Add details around configuration and options flow#12239
frenck merged 11 commits into
home-assistant:currentfrom
kit-klein:patch-4

Conversation

@kit-klein
Copy link
Copy Markdown
Contributor

@kit-klein kit-klein commented Mar 2, 2020

Proposed change

This PR adds missing details for the Konnected.io configuration flow based setup that was released in 0.106.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Mar 2, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things provided as suggestions.

In general, I think we should avoid the terms "configuration flow" or "options flow", these are terms used internally as developers. However, users aren't familiar with those terms, nor are they listed anywhere. In general, we refer to the "UI", "web interface" or the Home Assistant (web) frontend.

Comment thread source/_integrations/konnected.markdown Outdated
Comment thread source/_integrations/konnected.markdown Outdated
Comment thread source/_integrations/konnected.markdown Outdated
Comment thread source/_integrations/konnected.markdown Outdated
Comment thread source/_integrations/konnected.markdown Outdated
Comment thread source/_integrations/konnected.markdown Outdated
Comment thread source/_integrations/konnected.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 3, 2020
kit-klein and others added 7 commits March 3, 2020 17:47
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@kit-klein
Copy link
Copy Markdown
Contributor Author

Some small things provided as suggestions.

In general, I think we should avoid the terms "configuration flow" or "options flow", these are terms used internally as developers. However, users aren't familiar with those terms, nor are they listed anywhere. In general, we refer to the "UI", "web interface" or the Home Assistant (web) frontend.

Thank you for the clean up suggestions. I'll go through and replace up some of the technical terms (configuration.yaml) as well.

@kit-klein kit-klein removed their assignment Mar 6, 2020
@kit-klein
Copy link
Copy Markdown
Contributor Author

Some small things provided as suggestions.

In general, I think we should avoid the terms "configuration flow" or "options flow", these are terms used internally as developers. However, users aren't familiar with those terms, nor are they listed anywhere. In general, we refer to the "UI", "web interface" or the Home Assistant (web) frontend.

@frenck The latest commit removes the technical terminology. Let me know if you see anything else.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @kit-klein 👍

@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Mar 6, 2020
@frenck frenck merged commit 777a2f3 into home-assistant:current Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants