Skip to content

Dynalite - addition of switch platform#12227

Merged
frenck merged 7 commits into
home-assistant:nextfrom
ziv1234:patch-3
Mar 5, 2020
Merged

Dynalite - addition of switch platform#12227
frenck merged 7 commits into
home-assistant:nextfrom
ziv1234:patch-3

Conversation

@ziv1234
Copy link
Copy Markdown
Contributor

@ziv1234 ziv1234 commented Mar 1, 2020 •
edited
Loading

Proposed change

Additional documentation for the additional functionality in PR 32389

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added next This PR goes into the next branch has-parent This PR has a parent PR in another repo labels Mar 1, 2020
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Mar 2, 2020
frenck
frenck requested changes Mar 2, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ziv1234!

I've reviewed it and left some suggestions. Could you please take a look? Thanks! 👍

Comment thread source/_integrations/dynalite.markdown Outdated
Comment thread source/_integrations/dynalite.markdown Outdated
Comment thread source/_integrations/dynalite.markdown Outdated
Comment thread source/_integrations/dynalite.markdown Outdated
Comment thread source/_integrations/dynalite.markdown Outdated
Comment thread source/_integrations/dynalite.markdown Outdated
@frenck frenck changed the title Update dynalite.markdown Dynalite - addition of switch platform Mar 2, 2020
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 2, 2020
ziv1234 and others added 6 commits March 2, 2020 18:19
@ziv1234
removed tab
e263fde
@ziv1234 @frenck
Update source/_integrations/dynalite.markdown
6f7a711 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@ziv1234 @frenck
Update source/_integrations/dynalite.markdown
8a29ccf 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@ziv1234 @frenck
Update source/_integrations/dynalite.markdown
5d271fd 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@ziv1234 @frenck
Update source/_integrations/dynalite.markdown
72fb07b 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@ziv1234 @frenck
Update source/_integrations/dynalite.markdown
b47ef2d 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@ziv1234
Copy link
Copy Markdown
Contributor Author

ziv1234 commented Mar 2, 2020

accepted all the changes

frenck
frenck approved these changes Mar 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Mar 3, 2020
@ziv1234 ziv1234 mentioned this pull request Mar 3, 2020
Merged
20 tasks
@ziv1234
Copy link
Copy Markdown
Contributor Author

ziv1234 commented Mar 3, 2020

thanks! waiting for the code PR now. appreciate the quick reply

@frenck frenck added the parent-merged The parent PR has been merged already label Mar 5, 2020
@frenck frenck merged commit 4fd1b85 into home-assistant:next Mar 5, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Mar 5, 2020
@ziv1234
Copy link
Copy Markdown
Contributor Author

ziv1234 commented Mar 5, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

Assignees

No one assigned

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ziv1234 @frenck