Skip to content

Table to better understand ZHA Radio Types & HW#12216

Merged
frenck merged 4 commits into
home-assistant:currentfrom
rosscullen:patch-3
Mar 4, 2020
Merged

Table to better understand ZHA Radio Types & HW#12216
frenck merged 4 commits into
home-assistant:currentfrom
rosscullen:patch-3

Conversation

@rosscullen
Copy link
Copy Markdown
Contributor

@frenck when you get a chance, could you review the proposed? From doing a ZHA Integrations install today (after seeing your livestream topic this week), I didn't know which radio type to pick for a Conbee II. Hopefully this table will help users with their install.

It's hard to figure out which hardware is compatible with some of the radio types. Would you or someone be able to validate and/or add in the other Radio Hardware to the table? Thank you!

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@frenck when you get a chance, could you review the proposed? From doing a ZHA Integrations install today (after seeing your livestream topic this week), I didn't know which radio type to pick for a Conbee II. Hopefully this table will help users with their install. 

It's hard to figure out which hardware is compatible with some of the radio types. Would you or someone  be able to validate and/or add in the other Radio Hardware to the table? Thank you!
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Feb 29, 2020
@Adminiuga
Copy link
Copy Markdown
Contributor

Please add Zigate and TI CC based radios. See #12220

Copy link
Copy Markdown
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/runner/work/home-assistant.io/home-assistant.io/source/_integrations/zha.markdown
  86:3  ✓ error  Incorrect usage of the term: “deconz”, use “deCONZ” instead  terminology

@Adminiuga
Copy link
Copy Markdown
Contributor

hrm, in that context it is talking about "radio types" available in the drop down box when you configure ZHA integration config_entry. All those radio types are in lower case.
So the question here: Do we document it "case insensitively" or should it be documented matching letter by letter.

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 2, 2020

They need to code blocked. Will add review suggestion to address the build.

Comment thread source/_integrations/zha.markdown Outdated
Comment thread source/_integrations/zha.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 2, 2020
@Gamester17
Copy link
Copy Markdown
Contributor

@rosscullen, good point. I have also tried to make radio-type choice a little bit clearer in PR #12233

@Gamester17
Copy link
Copy Markdown
Contributor

Should also the default device port path be documented too?

ConBee I = /dev/ttyUSBx
ConBee II = /dev/ttyACMx
RaspBee I / II = /dev/ttyAMA0 or /dev/ttyS0

Texas Instruments CC2531 = /dev/ttyACM0

ZiGate USB-TTL / USB-DIN = /dev/ttyUSB0

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 3, 2020

@Gamester17 You can't state that it can differ on systems depending on how it is hooked up. Furthermore, I definitely do not recommend using those device paths, instead use the serial by id path, as they are stable.

rosscullen and others added 2 commits March 3, 2020 22:22
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Copy link
Copy Markdown
Contributor Author

@rosscullen rosscullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes commited. Please can someone approve? I will try and review the page in further detail at a later stage. Thanks

frenck
frenck previously approved these changes Mar 4, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rosscullen! 👍

@frenck frenck merged commit 083e73d into home-assistant:current Mar 4, 2020
@probot-home-assistant probot-home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Mar 4, 2020
felipediel pushed a commit to felipediel/home-assistant.io that referenced this pull request Mar 6, 2020
* Table to better understand ZHA Radio Types & HW

@frenck when you get a chance, could you review the proposed? From doing a ZHA Integrations install today (after seeing your livestream topic this week), I didn't know which radio type to pick for a Conbee II. Hopefully this table will help users with their install. 

It's hard to figure out which hardware is compatible with some of the radio types. Would you or someone  be able to validate and/or add in the other Radio Hardware to the table? Thank you!

* Update source/_integrations/zha.markdown

Co-Authored-By: Franck Nijhof <frenck@frenck.nl>

* Update source/_integrations/zha.markdown

Co-Authored-By: Franck Nijhof <frenck@frenck.nl>

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
felipediel pushed a commit to felipediel/home-assistant.io that referenced this pull request Mar 6, 2020
* Table to better understand ZHA Radio Types & HW

@frenck when you get a chance, could you review the proposed? From doing a ZHA Integrations install today (after seeing your livestream topic this week), I didn't know which radio type to pick for a Conbee II. Hopefully this table will help users with their install. 

It's hard to figure out which hardware is compatible with some of the radio types. Would you or someone  be able to validate and/or add in the other Radio Hardware to the table? Thank you!

* Update source/_integrations/zha.markdown

Co-Authored-By: Franck Nijhof <frenck@frenck.nl>

* Update source/_integrations/zha.markdown

Co-Authored-By: Franck Nijhof <frenck@frenck.nl>

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@rosscullen rosscullen deleted the patch-3 branch March 6, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants