Skip to content

Add docs for new integration PVPC hourly pricing#12194

Merged
bdraco merged 8 commits into
home-assistant:nextfrom
azogue:new-integration/pvpc_hourly_pricing
Mar 22, 2020
Merged

Add docs for new integration PVPC hourly pricing#12194
bdraco merged 8 commits into
home-assistant:nextfrom
azogue:new-integration/pvpc_hourly_pricing

Conversation

@azogue
Copy link
Copy Markdown
Member

@azogue azogue commented Feb 27, 2020

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Feb 27, 2020
@azogue azogue added the new-integration This PR adds documentation for a new Home Assistant integration label Feb 27, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @azogue!

Reviewed it and left some comments/suggestions. Could you please take a look? Thanks! 👍

Comment thread source/_integrations/pvpc_hourly_pricing.markdown Outdated
Comment thread source/_integrations/pvpc_hourly_pricing.markdown Outdated
Comment thread source/_integrations/pvpc_hourly_pricing.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 2, 2020
@azogue
Copy link
Copy Markdown
Member Author

azogue commented Mar 3, 2020

Reviewed it and left some comments/suggestions. Could you please take a look? Thanks! 👍

Hi @frenck, thanks for reviewing it :)

I was AFK for some days, I'll do it over this week

@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Mar 4, 2020
frenck
frenck previously approved these changes Mar 4, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Mar 4, 2020
@azogue
Copy link
Copy Markdown
Member Author

azogue commented Mar 4, 2020

Can be merged as soon as the parent PR gets merged.

For the parent PR I'm also doing some changes on the used endpoint for the pricing API (moving from xml file to JSON, as I'm experiencing better availability for that one),

so it may take a bit

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 4, 2020

That is OK, it will wait in the "awaits-parent" lane until the parent is ready.

frenck
frenck previously approved these changes Mar 18, 2020
- Remove manual platform setup
- Remove tariff change via options
@bdraco bdraco added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Mar 22, 2020
@bdraco bdraco merged commit fe54672 into home-assistant:next Mar 22, 2020
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Mar 22, 2020
@azogue azogue deleted the new-integration/pvpc_hourly_pricing branch March 23, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants