Skip to content

Emoncms API now provides a Unit of Measurement#12153

Merged
frenck merged 7 commits into
home-assistant:nextfrom
borpin:bpo-emoncms
Mar 5, 2020
Merged

Emoncms API now provides a Unit of Measurement#12153
frenck merged 7 commits into
home-assistant:nextfrom
borpin:bpo-emoncms

Conversation

@borpin
Copy link
Copy Markdown
Contributor

@borpin borpin commented Feb 21, 2020

Proposed change

Update to add a variable to use the Unit of measurment included in the Emoncms API call.

Minor other enhancements.

As a user is required to add a variable to make the change this should be regarded as non-breaking.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Update to add a variable to use the Unit of measurment included in the Emoncms API call.

Minor other enhancements
@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Feb 21, 2020
@borpin
Copy link
Copy Markdown
Contributor Author

borpin commented Feb 21, 2020

I note that the Lint Text check has failed. I cannot see where 'emoncms' has been used in place of 'Emoncms' within the text.

Comment thread source/_integrations/emoncms.markdown
@klaasnicolaas klaasnicolaas self-assigned this Feb 21, 2020
Comment thread source/_integrations/emoncms.markdown Outdated
@borpin
Copy link
Copy Markdown
Contributor Author

borpin commented Feb 22, 2020

@klaasnicolaas, thanks - I just followed what was there.

As this uses a template, is there a way to get VSCode to preview it correctly do you know?

@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 22, 2020

Adjusted PR to pass the build.

@frenck frenck changed the title Update emoncms.markdown Emoncms API now provides a Unit of Measurement Feb 22, 2020
Comment thread source/_integrations/emoncms.markdown Outdated
Comment thread source/_integrations/emoncms.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Feb 22, 2020
@frenck frenck assigned borpin and unassigned klaasnicolaas Feb 22, 2020
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Feb 22, 2020
borpin and others added 2 commits February 22, 2020 14:42
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@borpin borpin requested a review from frenck February 22, 2020 15:18
frenck
frenck previously approved these changes Feb 22, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck requested a review from klaasnicolaas February 22, 2020 16:05
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Feb 22, 2020
klaasnicolaas
klaasnicolaas previously approved these changes Feb 23, 2020
@klaasnicolaas klaasnicolaas added the awaits-parent Awaits the merge of an parent PR label Feb 23, 2020
Updated to reflect agreed code PR
@borpin borpin dismissed stale reviews from klaasnicolaas and frenck via 6d1150a February 25, 2020 20:46
@borpin
Copy link
Copy Markdown
Contributor Author

borpin commented Feb 25, 2020

Updated to match agreed parent PR

@frenck frenck added the parent-merged The parent PR has been merged already label Mar 5, 2020
@frenck frenck merged commit a70c1b8 into home-assistant:next Mar 5, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants