Emoncms API now provides a Unit of Measurement#12153
Merged
Merged
Conversation
Update to add a variable to use the Unit of measurment included in the Emoncms API call. Minor other enhancements
20 tasks
Contributor
Author
|
I note that the Lint Text check has failed. I cannot see where 'emoncms' has been used in place of 'Emoncms' within the text. |
klaasnicolaas
requested changes
Feb 21, 2020
Contributor
Author
|
@klaasnicolaas, thanks - I just followed what was there. As this uses a template, is there a way to get VSCode to preview it correctly do you know? |
Member
|
Adjusted PR to pass the build. |
frenck
requested changes
Feb 22, 2020
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
frenck
previously approved these changes
Feb 22, 2020
Member
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
klaasnicolaas
previously approved these changes
Feb 23, 2020
Updated to reflect agreed code PR
Contributor
Author
|
Updated to match agreed parent PR |
frenck
approved these changes
Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Update to add a variable to use the Unit of measurment included in the Emoncms API call.
Minor other enhancements.
As a user is required to add a variable to make the change this should be regarded as non-breaking.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.