Added documentation for the bmp280 integration#11769
Merged
Merged
Conversation
9 tasks
probot-home-assistant
Bot
added
the
has-parent
Contributor
Author
|
PR for the integration is home-assistant/core#30837 |
frenck
added
the
new-integration
frenck
previously approved these changes
Jan 20, 2020
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
ha_release might need an update before merging this one in.
mrand
reviewed
Jan 28, 2020
Co-Authored-By: Marc Randolph <mrand@users.noreply.github.com>
frenck
requested changes
Mar 22, 2020
frenck
added
in-progress
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
frenck
approved these changes
Mar 22, 2020
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
frenck
added
awaits-parent
Member
|
@frenck Does this needs a logo in brands? |
Member
|
@bdraco No it does not, we don't require those on PR's that were created before it even existed. After gaining some experience with the brands we go look into enforcement. |
probot-home-assistant
Bot
added
the
parent-merged
probot-home-assistant
Bot
removed
awaits-parent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added documentation for the BMP280 integration.
I can't provide the PR for the integration itself yet as I'm required to provide the number of this PR. There's a bit of a chicken and the egg problem here.
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.