Remove empty entity_id from light doc#11602
Closed
fhoekstra wants to merge 1 commit into
Closed
Conversation
As per 0.103, entity_id is non-optional and entity_id: all should be used to target all.
probot-home-assistant
Bot
added
has-parent
frenck
requested changes
Jan 2, 2020
Member
There was a problem hiding this comment.
Hi there, @fhoekstra!
This is a change to our current documentation and does not depend on the next release of Home Assistant. Therefore this PR should be based on and targeting the current branch.
Please change the target and rebase your PR if needed.
Thanks! 👍
frenck
added
in-progress
Member
|
This change is actually incorrect. Entity ID's are optional (for example an area can be provided instead). |
probot-home-assistant
Bot
removed
needs-rebase
Contributor
Author
|
Thanks for your responses @frenck ! |
2 tasks
Contributor
Author
|
Made a new PR for current. Look forward to your comments on that one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Leaving entity_id empty to target all has been deprecated, and is now non-functional since 0.103: home-assistant/core#29178
In this commit, I patch the light doc page (probably the most visited one). Let me know if you want me to do this for all integrations. I was not 100% sure if this change is across all integrations.
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.