Update docs to change domain for local_file service to reflect code changes#11234
Merged
frenck merged 1 commit intoNov 26, 2019
Conversation
probot-home-assistant
Bot
added
has-parent
9 tasks
raman325
changed the title
probot-home-assistant
Bot
added
the
parent-merged
frenck
approved these changes
Nov 26, 2019
probot-home-assistant
Bot
removed
the
parent-merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update the domain and service name for
camera.local_file_update_file_pathtolocal_file.update_file_path. I started down this path because of home-assistant/core#27289 and based on the introduction here and comment here, I felt this change made sense. If I am misunderstanding the intent please let me know so that I don't keep moving through these changes, as I have noticed this pattern emerging across a bunch of integrations as I commented here. Unfortunately I don't have a device to test most of these integrations.Pull request in home-assistant (if applicable): home-assistant/core#28890
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.