clarify options' use#11189
Merged
Merged
Conversation
The current description looks outdated to me because: 1. In Lovelace the time/date is not displayed when we open default_view 2. If only - 'time' specified, no `sensor.date` or anything else exists (and it's not clear as the configuration variable name is `display_options` (maybe now it's better to make it deprecated and change to `options` or something)?
frenck
requested changes
Nov 16, 2019
typo Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
frenck
approved these changes
Nov 28, 2019
probot-home-assistant
Bot
removed
the
in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current description looks outdated to me because:
sensor.dateor anything else exists (and it's not clear as the configuration variable name isdisplay_options(maybe now it's better to make it deprecated and change tooptionsor something)?Description:
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.