Skip to content

Update with added options for multiple event types and emulated key hold events.#10836

Merged
frenck merged 3 commits into
home-assistant:nextfrom
bendavid:patch-1
Nov 6, 2019
Merged

Update with added options for multiple event types and emulated key hold events.#10836
frenck merged 3 commits into
home-assistant:nextfrom
bendavid:patch-1

Conversation

@bendavid
Copy link
Copy Markdown
Contributor

Corresponding to home-assistant/core#27761

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 16, 2019
Comment thread source/_integrations/keyboard_remote.markdown Outdated
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the build passes.

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Oct 17, 2019
@bendavid
Copy link
Copy Markdown
Contributor Author

I believe all of the previous comments have been addressed now.

frenck
frenck previously approved these changes Oct 20, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Oct 20, 2019
@frenck frenck changed the base branch from current to next October 20, 2019 19:06
@probot-home-assistant probot-home-assistant Bot added next This PR goes into the next branch and removed current This PR goes into the current branch labels Oct 20, 2019
@MartinHjelmare MartinHjelmare added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Oct 28, 2019
@frenck frenck merged commit f58f755 into home-assistant:next Nov 6, 2019
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants