Skip to content

Added missing services to Nuki#10822

Closed
noxhirsch wants to merge 1 commit into
home-assistant:currentfrom
noxhirsch:patch-8
Closed

Added missing services to Nuki#10822
noxhirsch wants to merge 1 commit into
home-assistant:currentfrom
noxhirsch:patch-8

Conversation

@noxhirsch
Copy link
Copy Markdown
Contributor

@noxhirsch noxhirsch commented Oct 16, 2019

I added the missing services unlock and lock to the services list.

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

I added the missing services `unlock` and `lock` to the services list.
@probot-home-assistant probot-home-assistant Bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 16, 2019
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 16, 2019

These should not be added since these are not part of the Nuki integration, but part of Home Assitant's Lock integration itself (like service lock.open). See: https://www.home-assistant.io/integrations/lock

If anything, the open should be removed from this page.

Nevertheless, thank you for your contribution, which is appreciated! 👍

@frenck frenck closed this Oct 16, 2019
@probot-home-assistant probot-home-assistant Bot added Invalid and removed Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 16, 2019
@noxhirsch noxhirsch mentioned this pull request Oct 16, 2019
2 tasks
fabaff pushed a commit that referenced this pull request Oct 16, 2019
I removed service `open` because it's part of HA's lock integration 
(FollowUp to #10822)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch Invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants