Skip to content

Document new 'register_type' parameter for modbus binary sensor#10689

Closed
keton wants to merge 1 commit into
home-assistant:nextfrom
keton:next
Closed

Document new 'register_type' parameter for modbus binary sensor#10689
keton wants to merge 1 commit into
home-assistant:nextfrom
keton:next

Conversation

@keton
Copy link
Copy Markdown

@keton keton commented Oct 10, 2019

Description:

Pull request in home-assistant (if applicable): home-assistant/core#27397

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 10, 2019
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Oct 10, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @keton!

I've reviewed it and left a comment. Could you please take a look? Thanks! 👍

Comment thread source/_integrations/binary_sensor.modbus.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Oct 10, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Oct 11, 2019
@probot-home-assistant probot-home-assistant Bot added Invalid and removed awaits-parent Awaits the merge of an parent PR Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo Invalid next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants