Skip to content

Clean up duplicate section in Cast documentation#10497

Merged
frenck merged 1 commit into
home-assistant:currentfrom
benley:patch-1
Oct 12, 2019
Merged

Clean up duplicate section in Cast documentation#10497
frenck merged 1 commit into
home-assistant:currentfrom
benley:patch-1

Conversation

@benley
Copy link
Copy Markdown
Contributor

@benley benley commented Sep 30, 2019

Description:

It looks like this was introduced accidentally by some kind of glitch, because #10339 appears to have been merged twice: 48f38a5 added the section, followed by 0c2c8f8 on the same branch.

Pull request in home-assistant (if applicable): n/a

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Sep 30, 2019
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Sep 30, 2019
@frenck
Copy link
Copy Markdown
Member

frenck commented Sep 30, 2019

Hey @benley!

Thank you for the PR. Since this change has no dependency to an upcoming release (it has no parent PR that is pending release in our codebase), but a change to our documentation of or current release; this PR should target the current branch.

Please change the target branch of this PR to the current branch and rebase your PR if needed.

@emontnemery
Copy link
Copy Markdown
Contributor

emontnemery commented Oct 11, 2019

The "Advanced use" section is also duplicated, one is talking about Advanced use of the "Home Assistant Cast" feature, the other is talking about manually configuring chromecasts.

@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 11, 2019

A small and friendly notification.

@benley, Are you planning on moving forward on this PR?
I didn't see any activity recently, while there are still things to do. I hope you consider picking it up soon! 👍

@benley
Copy link
Copy Markdown
Contributor Author

benley commented Oct 11, 2019

Ah sorry, I lost track of the notification for this PR. I'll get it cleaned up for you.

@benley benley changed the base branch from next to current October 11, 2019 18:50
@probot-home-assistant probot-home-assistant Bot added current This PR goes into the current branch and removed next This PR goes into the next branch labels Oct 11, 2019
It looks like this was introduced accidentally by some kind of merge glitch: 48f38a5 added the section, followed by 0c2c8f8 on the same branch.
@benley
Copy link
Copy Markdown
Contributor Author

benley commented Oct 11, 2019

Fixed, I think.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @benley! 👍

Happy Hacktoberfest 🎉

@frenck frenck merged commit 4e1f6df into home-assistant:current Oct 12, 2019
@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants