Skip to content

Added 'availability_template' to all Template Lock platform#10307

Merged
frenck merged 4 commits into
home-assistant:nextfrom
grillp:next-avail-template-lock
Oct 2, 2019
Merged

Added 'availability_template' to all Template Lock platform#10307
frenck merged 4 commits into
home-assistant:nextfrom
grillp:next-avail-template-lock

Conversation

@grillp
Copy link
Copy Markdown
Contributor

@grillp grillp commented Sep 8, 2019

Added documentation availability_template configuration option for Template Lock platform components.

home-assistant/core#26517

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Sep 8, 2019
@frenck frenck added in-progress This PR/Issue is currently being worked on new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Sep 10, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @grillp (and thanks for splitting). I've reviewed it and left some comments. Could you please take a look?

Comment thread source/_components/lock.template.markdown Outdated
Comment thread source/_components/lock.template.markdown Outdated
frenck
frenck previously approved these changes Sep 11, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Sep 11, 2019
@frenck frenck added the parent-merged The parent PR has been merged already label Oct 1, 2019
@frenck frenck force-pushed the next-avail-template-lock branch from b03dbc1 to 3e19e30 Compare October 2, 2019 13:51
@frenck frenck self-assigned this Oct 2, 2019
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Oct 2, 2019
@frenck frenck force-pushed the next-avail-template-lock branch from 3e19e30 to 4f59623 Compare October 2, 2019 13:54
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @grillp! 🎉

@frenck frenck merged commit 4688830 into home-assistant:next Oct 2, 2019
@probot-home-assistant probot-home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Oct 2, 2019
@frenck frenck removed the awaits-parent Awaits the merge of an parent PR label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants