Skip to content

Change nzbget to full component#10300

Merged
MartinHjelmare merged 2 commits into
home-assistant:nextfrom
chriscla:patch-1
Sep 15, 2019
Merged

Change nzbget to full component#10300
MartinHjelmare merged 2 commits into
home-assistant:nextfrom
chriscla:patch-1

Conversation

@chriscla
Copy link
Copy Markdown
Contributor

@chriscla chriscla commented Sep 6, 2019

Description:
Companion pull request to proposed change that will change NZBGet component from solely a sensor platform to a full component

Pull request in home-assistant (if applicable): home-assistant/core/pull/26462

Checklist:

  • [X ] Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • [X ] The documentation follows the [standards][standards].

@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Sep 6, 2019
@DubhAd DubhAd added awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in another repo labels Sep 6, 2019
DubhAd
DubhAd previously approved these changes Sep 6, 2019
Copy link
Copy Markdown
Contributor

@DubhAd DubhAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when parent is merged

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @chriscla, I've reviewed your PR and thing there is something wrong. Could you please take a look? Thanks! 👍

Comment thread source/_components/nzbget.markdown Outdated
@frenck frenck added in-progress This PR/Issue is currently being worked on new-feature This PR adds documentation for a new Home Assistant feature to an existing integration and removed awaits-parent Awaits the merge of an parent PR labels Sep 6, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Sep 14, 2019
@frenck
Copy link
Copy Markdown
Member

frenck commented Sep 14, 2019

Thanks for fixing it @chriscla! 👍

@MartinHjelmare MartinHjelmare added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Sep 15, 2019
@MartinHjelmare MartinHjelmare merged commit 69c00ee into home-assistant:next Sep 15, 2019
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Sep 15, 2019
@bbrendon bbrendon mentioned this pull request Sep 23, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants