Add options to badges#10286
Merged
Merged
Conversation
probot-home-assistant
Bot
added
has-parent
balloob
approved these changes
Sep 3, 2019
balloob
previously approved these changes
Sep 3, 2019
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
ok to merge when the syntax error is fixed.
frenck
added
new-feature
Member
Author
|
@balloob I'm not seeing the error? |
Member
|
Neither do I, but netlify says |
Member
Author
|
I have no idea what that means 😂 |
Member
Author
|
@frenck any ideas by chance? |
fabaff
reviewed
Sep 10, 2019
Member
|
Hmm, I don't see a direct reason on why this fails. Will assign me and pick to one up later today. Interested to find out why this fails. |
Member
|
@iantrich Found it! Although, this is more a workaround. Our configuration plugin assumes an integration/component/platform page, which in this case, it isn't. Providing an additional (meaningless) argument to the Need to revisit the part of the code. For now, this build should pass. |
probot-home-assistant
Bot
removed
the
parent-merged
balloob
added
the
cherry-picked
balloob
pushed a commit
that referenced
this pull request
Sep 18, 2019
* Update views.markdown home-assistant/frontend#3552 * 🚑 Fixed build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
home-assistant/frontend#3552
Description:
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.