Skip to content

Updates docs for Jewish calendar#10231

Merged
frenck merged 2 commits into
home-assistant:nextfrom
tsvi:patch-4
Sep 9, 2019
Merged

Updates docs for Jewish calendar#10231
frenck merged 2 commits into
home-assistant:nextfrom
tsvi:patch-4

Conversation

@tsvi
Copy link
Copy Markdown
Contributor

@tsvi tsvi commented Aug 26, 2019

Updates for PR home-assistant/core#26200

Description:

  • Jewish calendar moved to platform
  • As per ADR 003, remove data selectors, instead describe the various sensors

Pull request in home-assistant (if applicable): home-assistant/core#26200

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Aug 26, 2019
Comment thread source/_components/jewish_calendar.markdown Outdated
@klaasnicolaas klaasnicolaas added the ready-for-review This PR needs to be reviewed label Aug 26, 2019
Co-Authored-By: Klaas Schoute <klaas_schoute@hotmail.com>
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR new-feature This PR adds documentation for a new Home Assistant feature to an existing integration and removed ready-for-review This PR needs to be reviewed labels Sep 3, 2019
@frenck frenck dismissed klaasnicolaas’s stale review September 3, 2019 09:45

comment addressed

@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Sep 6, 2019
@frenck
Copy link
Copy Markdown
Member

frenck commented Sep 9, 2019

Parent is merged 🎉
Let's merge this one in as well, thanks @tsvi! 👍

@frenck frenck merged commit 525f08e into home-assistant:next Sep 9, 2019
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Sep 9, 2019
@klaasnicolaas klaasnicolaas removed the awaits-parent Awaits the merge of an parent PR label Sep 9, 2019
@bbrendon bbrendon mentioned this pull request Sep 23, 2019
2 tasks
@tsvi tsvi deleted the patch-4 branch May 23, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants