CoolMaster: Change auto to heat_cool#10209
Merged
Merged
Conversation
probot-home-assistant
Bot
added
has-parent
5 tasks
frenck
previously approved these changes
Aug 23, 2019
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
frenck
added
awaits-parent
probot-home-assistant
Bot
added
the
parent-merged
Contributor
Author
|
@frenck Thanks. The parent PR is now merged. |
klaasnicolaas
previously approved these changes
Aug 23, 2019
Member
|
Could you resolve the merge conflict? As far as I see, your fork still has an old version of our repo. Make sure that it is up to date. |
OnFreund
force-pushed
the
auto_to_heat_cool
branch
from
4c87e2d to
8b00d8d
Compare
Contributor
Author
|
@klaasnicolaas really strange. Not sure how this happened. I rebased on top of upstream/next and should be ok now. |
klaasnicolaas
approved these changes
Aug 25, 2019
Member
|
Yes we can merge now 😄 |
probot-home-assistant
Bot
removed
the
parent-merged
balloob
added
the
cherry-picked
balloob
pushed a commit
that referenced
this pull request
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Changing the
automode to aheat_coolmode in CoolMaster to better reflect what it does.Pull request in home-assistant (if applicable): home-assistant/core#26144
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.