Fix opening edit dialog twice when closed by clicking on overlay#2290
Merged
Fix opening edit dialog twice when closed by clicking on overlay#2290
Conversation
ghost
assigned
Member
|
This was intentional at first, clicking cancel would cancel, clicking outside the dialog would close not cancel, opening the same again would get you on the same position as you left. On opening another element it updated. |
Member
Author
|
I don't think users expect such behavior. |
Member
|
I'm fine with this :) Idea was for clicking next to the dialog by accident. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the edit dialog was closed by clicking on the overlay, we didn't reset the state of the edit dialog manager. This meant that if we tried to open it again, it would render the same element, which meant it didn't need to change anything, and so also didn't reset
opened.Fixing by listening to when dialog is closed and calling cancel.
Fixes #2283