Merged
Conversation
Member
balloob
commented
Dec 17, 2018
balloob
commented
- Fix setting aspect ratio in percentage (Fix setting aspect ratio in percentage #2289) @balloob
- Fix opening edit dialog twice when closed by clicking on overlay (Fix opening edit dialog twice when closed by clicking on overlay #2290) @balloob
- Call super updated (Call super updated #2293) @balloob
- remove Animation for thermostat and light (remove Animation for thermostat and light #2303) @zsarnett
- Fix for element positioning (Fix for element positioning #2335) @iantrich
- Fix undefined on plant/weather card (Fix undefined on plant/weather card #2339) @balloob
- Fix service button element (Fix service button element #2343) @balloob
* Fix setting aspect ratio in percentage * Use endsWith * Fix invalid test
* Update Animation * Update light
* Fix for element positioning * Address comments
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.