Conversation
4 tasks
Contributor
|
The alerts are just for debug, right? |
Member
Author
|
They are not for debug, they are more a temporary stopfix until I redesign and localise everything. Previously we would just get a console error. |
balloob
force-pushed
the
config-entry-select
branch
from
fa042a1 to
1cd4495
Compare
Member
Author
|
I've removed the alerts. Now if a config flow aborts/finishes right away, it will be displayed in the same form as any "abort" or "finish" message that is received by interacting with a flow. |
andrey-git
reviewed
Mar 4, 2018
| * The step of the current selected flow, if available. | ||
| */ | ||
| _flowStep: Object, | ||
| _userCreatedFlow: Boolean, |
Contributor
There was a problem hiding this comment.
This is not used in bindings. Maybe make it a non-polymer property?
c727
reviewed
Mar 5, 2018
| this.userCreatedFlow = false; | ||
|
|
||
| this.setProperties({ | ||
| _flowId: null, |
balloob
force-pushed
the
config-entry-select
branch
from
190c3c5 to
580741e
Compare
andrey-git
approved these changes
Mar 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes for config entries: