Skip to content

Fix resetting theme, only fallback to light when theme doesnt support…#9253

Merged
bramkragten merged 1 commit intodevfrom
fix-resetting-theme
May 25, 2021
Merged

Fix resetting theme, only fallback to light when theme doesnt support…#9253
bramkragten merged 1 commit intodevfrom
fix-resetting-theme

Conversation

@bramkragten
Copy link
Copy Markdown
Member

… modes

Proposed change

Fixes resetting the theme (we edited the darkStyles object 🙈 )

Removes fallback to dark theme when theme doesn't have the light mode.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit de09e31 into dev May 25, 2021
@bramkragten bramkragten deleted the fix-resetting-theme branch May 25, 2021 22:11
@bramkragten bramkragten mentioned this pull request May 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants