Skip to content

Optimise data table and device dashboard#9217

Merged
bramkragten merged 1 commit intodevfrom
data-table-fixes
May 25, 2021
Merged

Optimise data table and device dashboard#9217
bramkragten merged 1 commit intodevfrom
data-table-fixes

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented May 20, 2021

Proposed change

We refresh the data when the location changed, causing a lot of unneeded updates when going to a detail and back.

Also fixes an issue where an item of virtualize scroll was undefined...

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 8af05e2 into dev May 25, 2021
@bramkragten bramkragten deleted the data-table-fixes branch May 25, 2021 11:12
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants