Skip to content

Remove padding when narrow#9209

Merged
balloob merged 1 commit intodevfrom
remove-padding-narrow
May 22, 2021
Merged

Remove padding when narrow#9209
balloob merged 1 commit intodevfrom
remove-padding-narrow

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented May 19, 2021

Breaking change

Proposed change

Before:
image

After:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

:host([narrow]) {
padding: 0 16px;
}
:host([narrow]) div {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the line above it instead

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nevermind that's different selector

@balloob balloob merged commit abb9f8e into dev May 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-padding-narrow branch May 22, 2021 13:12
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System icon missing in mobile view

3 participants